Conversation
googlebot
added
the
cla: yes
|
Hmm |
|
I also love scipy! |
Contributor
Author
|
test3 |
|
Starting a new build on Jenkins! |
|
test4 |
|
Build finished. |
.gitignore
Outdated
Contributor
There was a problem hiding this comment.
Just add this to the .gitignore in /appengine/flexible/scipy.
| app_path = os.path.dirname(os.path.realpath(__file__)) | ||
| image_path = os.path.join(app_path, 'assets/google_logo.jpg') | ||
| img = scipy.misc.imread(image_path) | ||
| img_tinted = scipy.misc.imresize(img, (300, 300)) |
Contributor
There was a problem hiding this comment.
perhaps img_resized instead? Also, update the comment in line 34
Contributor
There was a problem hiding this comment.
It's been merged and Bill's at burning man, man. Send a PR if you feel strongly.
Contributor
There was a problem hiding this comment.
Just catching up on email 😅
| img = scipy.misc.imread(image_path) | ||
| img_tinted = scipy.misc.imresize(img, (300, 300)) | ||
| output_image_path = os.path.join( | ||
| app_path, 'assets/resized_google_logo.jpg') |
Contributor
There was a problem hiding this comment.
Probably unnecessary to have the resized file checked in, since that's what you're generating..
8 tasks
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: https://github.com/googleapis/googleapis-gen/commit/7bf29a414b9ecac3170f0b65bdc2a95705c0ef1a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to keep this pretty simple just to demonstrate it works on Flex.
Could use GCS to make it a little less clumsy but leaned towards simplicity.